Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQL label missing for non-group-by queries #29420

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

hexcafe
Copy link
Contributor

@hexcafe hexcafe commented Jun 30, 2024

SUMMARY

Issue: Currently, the column label is not working if the query is not an aggregate query.

Steps to Reproduce:

  1. Create a chart with type table.
  2. Set QUERY MODE to Raw records.
  3. Rename any column.
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hexcafe hexcafe changed the title fix:fix the SQL label missing for non-group-by queries fix: SQL label missing for non-group-by queries Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (76d897e) to head (639518f).
Report is 388 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29420       +/-   ##
===========================================
+ Coverage   60.48%   83.89%   +23.40%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37468    -38768     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31434    -14680     
+ Misses      28017     6034    -21983     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.10% <ø> (-0.06%) ⬇️
javascript ?
mysql 77.41% <ø> (?)
postgres 77.52% <ø> (?)
presto 53.72% <ø> (-0.08%) ⬇️
python 83.89% <ø> (+20.40%) ⬆️
sqlite 76.99% <ø> (?)
unit 59.65% <ø> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@villebro villebro merged commit 179cf26 into apache:master Jul 1, 2024
37 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jul 2, 2024
michael-s-molina pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants